[daisy] [JIRA] Commented: (DSY-538) Use publishing requests in Book Publication

[Bob Lannoy (JIRA)]

    [ http://issues.cocoondev.org//browse/DSY-538?page=comments#action_13513 ] 

Bob Lannoy commented on DSY-538:
--------------------------------

I've come across a problem when the executed publishing request contains a fragment  with an embedded image.
The error is : "ImageHandler: encountered img tag outside the context of a document."
I've found out that src/java/org/outerj/daisy/books/publisher/impl/dataretrieval/ImageHandler.java contains a condition that checks for a null documentid if an img-tag is encountered. I do not know why this is checked.
If I comment out this condition, everything keeps working and the publisher request is nicely integrated into my book.

So my proposal is:

Index: RELEASE_2_0_1/daisy/applications/daisywiki/frontend/src/java/org/outerj/daisy/books/publisher/impl/dataretrieval/ImageHandler.java
===================================================================
--- RELEASE_2_0_1/daisy/applications/daisywiki/frontend/src/java/org/outerj/daisy/books/publisher/impl/dataretrieval/ImageHandler.java	(revision 4356)
+++ RELEASE_2_0_1/daisy/applications/daisywiki/frontend/src/java/org/outerj/daisy/books/publisher/impl/dataretrieval/ImageHandler.java	(working copy)
@@ -66,8 +66,8 @@
             currentDocBranchId = Long.parseLong(attributes.getValue("branchId"));
             currentDocLanguageId = Long.parseLong(attributes.getValue("languageId"));
         } else if (uri.equals("") && localName.equals("img")) {
-            if (currentDocumentId == null)
-                throw new SAXException("ImageHandler: encountered img tag outside the context of a document.");
+            //if (currentDocumentId == null)
+            //    throw new SAXException("ImageHandler: encountered img tag outside the context of a document.");
 
             String src = attributes.getValue("src");
             if (src != null && !src.equals("")) {


> Use publishing requests in Book Publication
> -------------------------------------------
>
>          Key: DSY-538
>          URL: http://issues.cocoondev.org//browse/DSY-538
>      Project: Daisy
>         Type: New Feature
>   Components: Daisy Books
>     Versions: 2.0.1
>     Reporter: Bob Lannoy
>     Priority: Minor
>      Fix For: 2.2

>
> I've setup a Daisy site with several publicationtypes and I also use
> publishing requests to group some information into one page. 
> This works without a problem for the wiki. 
> Now I'm trying to create a book, but it seems like the pubreq I
> defined for the wiki isn't used. 
>  
> In the xml in the bookstore/<book>/data/documents directory I don't  see a p:group tag in the xml-documents. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira