[daisy] HTML Cleaner

[Michael Halpin]

K, I'll probably look into it within the next week.

-----Original Message-----
From: daisy-bounces at lists.cocoondev.org
[mailto:daisy-bounces at lists.cocoondev.org] On Behalf Of Karel Vervaeke
Sent: Monday, April 28, 2008 8:00 AM
To: Daisy: open source CMS - general mailinglist
Subject: RE: [daisy] HTML Cleaner

I had a closer look and unfortunately I have to confirm that the
htmlcleaner does indeed discard other attributes, so it is definitely
related to the HTMLCleaner.  Bruno remarked that it can be argued
whether this is a bug or the absence of a feature - but anyway it is
confusing that some elements are treated more equal than others (you can
add an attribute "chapter-id" to p elements with no problem).

I will create an issue in Jira; if you feel like fixing it, you need to
look at HtmlRepairer.java

Regards,
Karel


On Fri, 2008-04-25 at 11:37 -0500, Michael Halpin wrote:
> If I manually add the tag in the source-view mode and hit the clean
> button it removes the tag.
> 
> I tried using alt title and some other standard tag names but it
> faithfully cleans each away.
> 
> -----Original Message-----
> From: daisy-bounces at lists.cocoondev.org
> [mailto:daisy-bounces at lists.cocoondev.org] On Behalf Of Karel Vervaeke
> Sent: Tuesday, April 22, 2008 2:05 AM
> To: Daisy: open source CMS - general mailinglist
> Subject: RE: [daisy] HTML Cleaner
> 
> Are you sure the attribute is removed by the htmlcleaner and not later
> by one of the cocoon pipeline components? To check this, you should
> check the part data using
>
http://example.com/.../site/123-DSY/version/1/part/SimpleDocumentContent
> /data
> or use htmlarea in source-view mode and use the 'clean' button.
> 
> As a sidetrack, try calling your attribute "title" or "alt" (something
> that is in the html DTD). (This would not be a final solution but it
> would help identify the problem).
> 
> HTH,
> Karel
> 
> On Mon, 2008-04-21 at 16:30 -0500, Michael Halpin wrote:
> > I am running 2.1 at the moment.  I have not put them in the allowed
> div
> > or span classes because since it is not a class attribute.
> > 
> > -----Original Message-----
> > From: daisy-bounces at lists.cocoondev.org
> > [mailto:daisy-bounces at lists.cocoondev.org] On Behalf Of Sieranski,
> Greg
> > Sent: Monday, April 21, 2008 3:58 PM
> > To: open source CMS - general mailinglist
> > Subject: Re: [daisy] HTML Cleaner
> > 
> > Michael Halpin wrote:
> > >
> > > I have changed the following code in the htmlcleaner.xml file:
> > >
> > >  
> > >
> > >       <element name="span">
> > >
> > >         <attribute name="class"/>
> > >
> > >       </element>
> > >
> > >  
> > >
> > > To:
> > >
> > >  
> > >
> > >       <element name="span">
> > >
> > >         <attribute name="class"/>
> > >
> > >         <attribute name="chapter-id"/>
> > >
> > >       </element>
> > >
> > >  
> > >
> > > I have saved the file.  Uploaded the change, restarted daisy, and 
> > > cleared my browser cache but the cleaner is still removing my 
> > > chapter-id tags.  Any ideas?
> > >
> > >
> >
>
------------------------------------------------------------------------
> > >
> > > _______________________________________________
> > > daisy community mailing list
> > > Professional Daisy support:
> > http://outerthought.org/en/services/daisy/support.html
> > > mail to: daisy at lists.cocoondev.org
> > > list information:
http://lists.cocoondev.org/mailman/listinfo/daisy
> > >   
> > We have modified the htmlcleaner previously and had not problems
with
> it
> > 
> > picking up our changes. What version of Daisy are you running? Also,
> did
> > 
> > you put the elements in the:
> > 
> >  <allowed-div-classes>
> >  </allowed-div-classes>
> > 
> > or
> > 
> >  <allowed-span-classes>
> >  </allowed-span-classes>
> > 
> > Regards,
> > Greg Sieranski
> > _______________________________________________
> > daisy community mailing list
> > Professional Daisy support:
> > http://outerthought.org/en/services/daisy/support.html
> > mail to: daisy at lists.cocoondev.org
> > list information: http://lists.cocoondev.org/mailman/listinfo/daisy
> > _______________________________________________
> > daisy community mailing list
> > Professional Daisy support:
> http://outerthought.org/en/services/daisy/support.html
> > mail to: daisy at lists.cocoondev.org
> > list information: http://lists.cocoondev.org/mailman/listinfo/daisy
> _______________________________________________
> daisy community mailing list
> Professional Daisy support:
> http://outerthought.org/en/services/daisy/support.html
> mail to: daisy at lists.cocoondev.org
> list information: http://lists.cocoondev.org/mailman/listinfo/daisy
> _______________________________________________
> daisy community mailing list
> Professional Daisy support:
http://outerthought.org/en/services/daisy/support.html
> mail to: daisy at lists.cocoondev.org
> list information: http://lists.cocoondev.org/mailman/listinfo/daisy
_______________________________________________
daisy community mailing list
Professional Daisy support:
http://outerthought.org/en/services/daisy/support.html
mail to: daisy at lists.cocoondev.org
list information: http://lists.cocoondev.org/mailman/listinfo/daisy