[daisy] [JIRA] Commented: (DSY-405) Integrate tanuki wrapper scripts in Daisy build

[Andreas Deininger (JIRA)]

    [ http://issues.cocoondev.org//browse/DSY-405?page=comments#action_13075 ] 

Andreas Deininger commented on DSY-405:
---------------------------------------

> Some quick questions:
>
> - is it correct that almost all files below distro/windows-installer/wrapper/(service|bin|conf|logs) should be removed?

Yes. Actually I want to move distro/windows-installer/wrapper/(service|bin|conf|logs) to /distro/core/resources/wrapper/
I think this makes sense because
*now the wrapper is used in all builds, so I consider it a core component
* I don't want to maintain different wrapper configuration files etc. within the repository

However, this means that some refactoring of the windows-installer is needed. I will take care of that. 

 - the file distro/core/resources/wrapper/README.txt is only partially included in the patch, could you attach it to this issue?
 
I simply copied over the README.txt which from the windows installler, so nothing is actually missing:
http://svn.cocoondev.org/viewsvn/trunk/daisy/distro/windows-installer/wrapper/README.txt

You are right however, that this text should be amended/adapted.

> Partly clarifying my previous question: the files that should go in:
>
> distro/core/resources/wrapper/service
>
> are missing from the patch. I don't know if they're exactly the same as what was previous in the windows installer, maybe easiest if you can zip them together and attach them to this patch.

O.k. I see. I'll provide them together with the patch for the windows installer.

Another note: new versions of the binaries should be used. There's an attachment with this issue (DSY-405) that contains the binaries needed: wrapper.tar.bz2. Please use the files inside that archive to fill the subdirectories lib and bin (wrapper, wrapper.exe). Looks like you used the old ones from the windows installer?

> The patch is now partly committed (SVN rev 3821), missing are:
> - the files in core/resources/wrapper/service
> - the windows .template files (added dummy files for now -- they are missing > in the patch)
> - distro/core/resources/wrapper/README.txt
> - no commits done yet below distro/windows-installer

I'll take care of all that.

> And a question: any specific reason initmemory/maxmemory is commented out 
> in wrapper confs?

No.


> Integrate tanuki wrapper scripts in Daisy build
> -----------------------------------------------
>
>          Key: DSY-405
>          URL: http://issues.cocoondev.org//browse/DSY-405
>      Project: Daisy
>         Type: Improvement
>     Versions: public - 2.0
>     Reporter: Andreas Deininger
>     Priority: Minor
>  Attachments: tanuki_wrapper.diff, wrapper.diff, wrapper.diff, wrapper.tar.bz2
>
> The following patch integrates the tanuki wrapper scripts in the Daisy binary build.
> During build time, a self contained wrapper installation is created inside the daisy binaries, these scripts are automatically configured during the repository and daisy wiki initialisation (no manual configuration is needed afterwards).
> This patch also upgrades the tanuki wrapper inside the windows installer to the latest release.
> This patch is the linux part only though it already contains a some files  needed for the windows variant. I will finalize the windows part once this patch is committed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira