[daisy] [JIRA] Resolved: (DSY-372) issues with htmlcleaner and <ul>

[Bruno Dumon (JIRA)]

     [ http://issues.cocoondev.org//browse/DSY-372?page=all ]
     
Bruno Dumon resolved DSY-372:
-----------------------------

    Fix Version: 2.1
     Resolution: Fixed

Fixed in SVN rev 4250.

The problem was basically that gecko can't handle the correct HTML situation, which is that ul/ol should be nested inside li, not inside ul/ol. IE can handle it just fine though.

As solution, the HTML cleaner will force ul/ol to be nested inside the parent ul/ol, rather than li.

As a side effect of this fix, empty li's are also removed from document content. It could be made more advanced so that this only happens for empty li's introduced due to this restructuring, but that would take additional effort. Anyway, the gecko editor can't handle empty li's either, so it's better they're removed.

> issues with htmlcleaner and <ul>
> --------------------------------
>
>          Key: DSY-372
>          URL: http://issues.cocoondev.org//browse/DSY-372
>      Project: Daisy
>         Type: Bug
>   Components: HTML cleaner
>     Reporter: Bruno Dumon
>     Priority: Minor
>      Fix For: 2.1
>  Attachments: bad-ul-showcase.txt
>
> Submitted by Wim on the mailing list:
> I have been able (at last) to create some daisy - HTML which reproduces
> some annoying "features" that corrupt your text and bullet structure.
> The main problem - as I understand - is that the HTML cleaner leaves it
> like it is. So one can't get it right without hacking the HTML ... and
> it always happens on a moment when you have no time and just want to
> deliver a nice document.
> To demonstrate :
> 1) Create a new empty daisy document.
> 2) Switch to the HTML tag view
> 3) Open the attachment "bad-ul-showcase.txt" and copy/paste all the HTML
> into the newly created document replacing the initial content.
> 4) Save.
> 5) Reopen the document ... and follow the instructions.
> Normally manipulating the case (B) <ul> gets you into trouble. Of course
> this is a very small document but big enough to demonstrate. It's my
> believe this is an issue that should be looked after to avoid end-user
> frustration while editing via the wiki, so am I happy to be able to
> provide a reproducible description.
> Regards,
> Wim
> ps1.
> I have tested this on the http://demo.daisycms.org site
> ps2.
> No ... the case (B) wasn't a result of me manually playing with HTML 
> tags. It sometimes happens while editing and the cleaner doesn't get rid 
> of it. But previously I haven't been able to provide a sample.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira