[daisy] [JIRA] Commented: (DSY-473) Backup tool uses incorrect logic to determine location of conf & service dirs.

[Bruno Dumon (JIRA)]

    [ http://issues.cocoondev.org//browse/DSY-473?page=comments#action_13251 ] 

Bruno Dumon commented on DSY-473:
---------------------------------

The following code in your patch looks suspicious:

-        File confDir = new File(blobStoreDir.getParentFile(), "conf");
-        File serviceDir = new File(blobStoreDir.getParentFile(), "service");
+        File confDir = new File(dataDir.getParentFile(), "conf");
+        File serviceDir = new File(dataDir.getParentFile(), "service");

conf & service should be subdirectories of the datadir, but with dataDir.getParentFile(), you're locating them as siblings of the datadir (I think)

Since I'm not very familiar with the backup tool code, it would ease my mind if you could test this patch, both for backup and restore.

> Backup tool uses incorrect logic to determine location of conf & service dirs.
> ------------------------------------------------------------------------------
>
>          Key: DSY-473
>          URL: http://issues.cocoondev.org//browse/DSY-473
>      Project: Daisy
>         Type: Bug
>   Components: Backup
>     Reporter: Bruno Dumon
>     Priority: Minor
>  Attachments: DSY-473.diff
>
> The class DaisyEntryLoader contains these lines of code:
>         File confDir = new File(blobStoreDir.getParentFile(), "conf");
>         File serviceDir = new File(blobStoreDir.getParentFile(), "service");
> which determine the location of conf & service dirs based on the location of the blobstore dir. However, these should rather be determined relative to the repodata dir location, as the location of the blobstore dir itself is read from the myconfig.xml

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira