[daisy] [JIRA] Commented: (DSY-516) [PATCH] Fix PostgreSQL compatibility

[Bruno Dumon (JIRA)]

    [ http://issues.cocoondev.org//browse/DSY-516?page=comments#action_13295 ] 

Bruno Dumon commented on DSY-516:
---------------------------------

I have applied this patch, with further changes to the LocalWfPoolStrategy (one of the prepared statements was still created in the loop, and they were not closed in the finally block).

I've left out the change in JDBC driver version as it's not in the maven repository, and hence breaks the build. If you'd like me to add it to our repository, I need a download link.

I've also left in the "do not use this" remark.

> [PATCH] Fix PostgreSQL compatibility
> ------------------------------------
>
>          Key: DSY-516
>          URL: http://issues.cocoondev.org//browse/DSY-516
>      Project: Daisy
>         Type: Improvement
>   Components: Repository - database support
>     Versions: 2.1
>  Environment: Latest SVN
>     Reporter: Andreas Deininger
>     Priority: Minor
>  Attachments: postgresql-2.diff, postgresql-3.diff, postgresql.diff
>
> The uploaded patch fixes the broken PostgreSQL compatibility of daisy
> * renamed field name_ in table wf_pools to name_pool since it conflicts with name_ in table daisy_namespaces
> * minor changes to query/model/SqlGenerationContext.java in order to make SQL statements work with PostgreSQL
> * workflow/serverimpl/LocalWfPoolStrategy.java: adding users to workflow pool: PostgreSQL does not know INSERT IGNORE, so insert some logic to perform either an INSERT or an UPDATE, depending whether user record exists or not
> * upgrading to latest postgreSQL JDBC driver: postgresql-7.4-216.jdbc3.jar (jdbc drivers for postgresql 8.x do not seem to work)
> Also a small fix to <daisy-src>/README.txt is included

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira