[daisy] [JIRA] Commented: (DSY-516) [PATCH] Fix PostgreSQL compatibility

[Bruno Dumon (JIRA)]

    [ http://issues.cocoondev.org//browse/DSY-516?page=comments#action_13289 ] 

Bruno Dumon commented on DSY-516:
---------------------------------

I had a closer look at the changes to LocalWfPoolStrategy:

For the insert ignore issue, the update part is not necessary, so if the record already exists it can be left untouched.

The prepared statements should be created outside of the loop, instead of recreating them on each loop iteration. So you will need two of them.

The following remark won't be relevant after changing this, but just fyi: the statements should be closed, while the result sets don't necessarily need to be closed (result sets are automatically closed when the statement from which they were created is closed). OTOH, not closing statements will cause resource leakage.

> [PATCH] Fix PostgreSQL compatibility
> ------------------------------------
>
>          Key: DSY-516
>          URL: http://issues.cocoondev.org//browse/DSY-516
>      Project: Daisy
>         Type: Improvement
>   Components: Repository - database support
>     Versions: 2.1
>  Environment: Latest SVN
>     Reporter: Andreas Deininger
>     Priority: Minor
>  Attachments: postgresql-2.diff, postgresql.diff
>
> The uploaded patch fixes the broken PostgreSQL compatibility of daisy
> * renamed field name_ in table wf_pools to name_pool since it conflicts with name_ in table daisy_namespaces
> * minor changes to query/model/SqlGenerationContext.java in order to make SQL statements work with PostgreSQL
> * workflow/serverimpl/LocalWfPoolStrategy.java: adding users to workflow pool: PostgreSQL does not know INSERT IGNORE, so insert some logic to perform either an INSERT or an UPDATE, depending whether user record exists or not
> * upgrading to latest postgreSQL JDBC driver: postgresql-7.4-216.jdbc3.jar (jdbc drivers for postgresql 8.x do not seem to work)
> Also a small fix to <daisy-src>/README.txt is included

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira