[daisy] [JIRA] Commented: (DSY-441) ImagePreSaveHook should have some way to trigger its execution in case the source part data has not changed

[Marc Portier (JIRA)]

    [ http://issues.cocoondev.org//browse/DSY-441?page=comments#action_13105 ] 

Marc Portier commented on DSY-441:
----------------------------------

using imagewidth < 0 is a bit awkward since it can only be triggered programmaticaly (field is not editable in the wiki iirc)
(of course, the ugrade scnario suggests using document tasks anyway, but still)

my personal trigger, and IMHO the most logical one would be to just check that thumbnail and/or preview images don't exist yet (since that checks on the expected endresult effectively)

by the way: the generic 'expression' solution would cover that case, if  there would be a DoesNotHavePart(partname) 



> ImagePreSaveHook should have some way to trigger its execution in case the source part data has not changed
> -----------------------------------------------------------------------------------------------------------
>
>          Key: DSY-441
>          URL: http://issues.cocoondev.org//browse/DSY-441
>      Project: Daisy
>         Type: Improvement
>     Reporter: Bruno Dumon
>     Priority: Minor
>      Fix For: public - 2.0.1

>
> In Daisy 2.0, the ImagePreSaveHook was 'enhanced' to only redo its work when the part containing the image data changed.
> However, this makes it difficult to explicitly trigger the ImagePreSaveHook in cases like:
>  * an upgrade from a pre-1.5 Daisy is done
>  * the configuration of the image hook changed
>  * or some other reason (e.g. installing JAI) that would cause the image hook to behave in new ways
> The only way right now to do this is by making sure the image part data is changed, thus by effectively re-assigning the part data. While this works perfectly, it causes needless growth of the blobstore, and this is what this enhancement wanted to avoid in the first place.
> Possible solutions for triggering:
>  - some configurable field has some configurable value (e.g. ImageWidth is set to -1)
>  - or more generically, an expression evaluates to true on the document (using QueryManager.parsePredicateExpression)
>  - (add your own)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira