should repository-client-impl depend on repository-spi? (was Re: [daisy] Daisy Detachment - dependencies)

[Bruno Dumon]

On Wed, 2006-07-05 at 18:13 +0200, Marc Portier wrote:
> 
> Andreas Deininger wrote:
> > 2006/7/4, tim_cranfield at goldenboat.net <tim_cranfield at goldenboat.net>:
> >>
> >> Another NoClassDefFoundError comes for ExtensionRegistrar.
> >> Where can this be found?
> > 
> > In: daisy-repository-spi-1.x.jar
> > 
> 
> hm, but that looks like a jar this detachment-client shouldn't be
> dependent on, no?
> 
> I'm seeing the same error, and the stacktrace points me here:
> 
> > [java]      at org.outerj.daisy.detachment.DetachmentRepositoryTalker.<init>(DetachmentRepositoryTalker.java:24)
> 
> At the mentioned line there is:
> 
> > 
> > 24	RepositoryManager repositoryManager = 
> > 25		new RemoteRepositoryManager(connection.getUrl(), connection.getCredentials());
> 
> 
> Digging into this
> org.outerj.daisy.repository.clientimpl.RemoteRepositoryManager I noticed
> it implements org.outerj.daisy.repository.ExtensionRegistrar which in
> fact sits in the repository-spi.
> 
> Also the project.xml of repository-client-impl clearly states the
> dependency on repository-spi.
> 
> Is that what we really want?

yes, actually we do (at least, I do).

The repository client allows the registering of extensions, to make
available remote java API implementations of the repository server
extensions.

There is also a server-spi for specific server-side SPIs (Service
Provider Interfaces). (I was confused about this last time you asked me
about it)

> Should these extension-interfaces maybe move up to repository-api
> (looking at their package names?)

It are not APIs users of the repository should call, so I'd say no (the
package was indeed not choosen thoughtfully).

-- 
Bruno Dumon                             http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
bruno at outerthought.org                          bruno at apache.org